Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger evalation API to swagger #8312

Merged
merged 6 commits into from
Feb 6, 2020
Merged

Conversation

calecarter
Copy link
Contributor

Latest improvements:

Added missing triggerEvaluation API to PolicyInsights swagger

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pilor pilor added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 5, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 5, 2020
@pilor
Copy link
Contributor

pilor commented Feb 5, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 5, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 5, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/policyinsights/mgmt-v2018_04_04 [Logs]  [Release SDK Changes]
  • ⚠️sdk/policyinsights/mgmt-v2018_07_01_preview [Logs]  [Release SDK Changes]
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
      [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:94: error: '{' expected
      [mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
      [mvn] [ERROR]                                ^
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error: = expected
      [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
      [mvn] [ERROR]                                             ^
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error:  expected
      [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
      [mvn] [ERROR]                                                           ^
      [mvn] [ERROR] 
      [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
      [mvn] [ERROR] 
      [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/target/apidocs' dir.
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
    • ⚠️sdk/policyinsights/mgmt-v2019_10_01 [Logs]  [Release SDK Changes]
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
        [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:99: error: '{' expected
        [mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
        [mvn] [ERROR]                                ^
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error: = expected
        [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
        [mvn] [ERROR]                                             ^
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error:  expected
        [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
        [mvn] [ERROR]                                                           ^
        [mvn] [ERROR] 
        [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
        [mvn] [ERROR] 
        [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/target/apidocs' dir.
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Feb 5, 2020

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Feb 5, 2020

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1
      • ️✔️@azure/arm-policyinsights [Logs]  [Release SDK Changes]
        [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
        [npmPack] loaded rollup.config.js with warnings
        [npmPack] (!) Unused external imports
        [npmPack] default imported from external module 'rollup' but never used
        [npmPack] 
        [npmPack] ./esm/policyInsightsClient.js → ./dist/arm-policyinsights.js...
        [npmPack] created ./dist/arm-policyinsights.js in 482ms

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Feb 5, 2020

      azure-sdk-for-python - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b7bd004 with merge commit 97f9215. SDK Automation 13.0.17.20191226.1
      • ️✔️azure-mgmt-policyinsights [Logs]  [Release SDK Changes]
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [build_package] warning: no files found matching '*.py' under directory 'tests'
        [build_package] warning: no files found matching '*.yaml' under directory 'tests'
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [build_package] warning: no files found matching '*.py' under directory 'tests'
        [build_package] warning: no files found matching '*.yaml' under directory 'tests'

      Copy link
      Contributor

      @sandipsh sandipsh left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      :shipit:

      @pilor
      Copy link
      Contributor

      pilor commented Feb 5, 2020

      @myronfanqiu ready for you

      @mmyyrroonn
      Copy link
      Contributor

      @pilor @calecarter Good work. Merged it. Thanks!

      @mmyyrroonn mmyyrroonn merged commit 97f9215 into Azure:master Feb 6, 2020
      ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants